Skip to content

Conversation

ioanatflowcrypt
Copy link
Collaborator

@ioanatflowcrypt ioanatflowcrypt commented Jul 23, 2025

This PR upgraded openpgp to v6.2

close #6049 // if this PR closes an issue


Tests (delete all except exactly one):

  • Does not need tests (refactor only, docs or internal changes)

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

  • addresses the issue it closes (if any)
  • code is readable and understandable
  • is accompanied with tests, or tests are not needed
  • is free of vulnerabilities
  • is documented clearly and usefully, or doesn't need documentation

@ioanatflowcrypt ioanatflowcrypt marked this pull request as ready for review July 24, 2025 00:27
}

public static isBaseKeyPacket(p: OpenPGP.BasePacket): p is OpenPGP.BasePublicKeyPacket {
public static isBaseKeyPacket(p: OpenPGP.BasePacket): p is OpenPGP.AnyKeyPacket {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we don't use this method anywhere, let's remove it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

Copy link
Collaborator

@sosnovsky sosnovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sosnovsky sosnovsky merged commit d0ee03f into master Jul 25, 2025
12 checks passed
@sosnovsky sosnovsky deleted the 6049-upgrade-to-openpgpjs-620 branch July 25, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to openpgpjs 6.2.0

2 participants